Hi Uli, On Thu, Feb 15, 2018 at 1:01 PM, Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> wrote: > This patch adds VIN4 and VIN5 pins, groups and functions for the > R8A7796 SoC. > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> However, I guess you can use union vin_data and VIN_DATA_PIN_GROUP() to reduce duplication, like on R-Car Gen2? Would there be a use case for vin4_data4 and vin5_data4, or is that mode only supported on R-Car H2? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds