> - if ((client->addr == 0x58 && !strcmp(client->name, "da9063")) ||
> - (client->addr == 0x68 && !strcmp(client->name, "da9210")) ||
> - (client->addr == 0x70 && !strcmp(client->name, "da9210"))) {
> + if (regulator_quirk_check(client, 0, "da9063") ||
> + regulator_quirk_check(client, 1, "da9210") ||
> + regulator_quirk_check(client, 2, "da9210")) {
I am afraid I don't think this makes the code better, just different.
The index is as magic as the client address IMO. I was not super happy
with the array size depending on the detected board from a previous
patch already. But given the next patch which modifies the msg array
depending on the board, I think we really need to switch to seperate
message arrays per board. Everything else is too error prone and
unnecessarily cumbersome to understand.
Other opinions?
Regards,
Wolfram
Attachment:
signature.asc
Description: PGP signature
