On 02/06/2018 03:04 PM, Geert Uytterhoeven wrote:
>> Define the generic R8A77980 part of the EtherAVB device node.
>>
>> Based on the original (and large) patch by Vladimir Barinov.
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> @@ -164,6 +164,50 @@
>> status = "disabled";
>> };
>>
>> + avb: ethernet@e6800000 {
>> + compatible = "renesas,etheravb-r8a77980",
>> + "renesas,etheravb-rcar-gen3";
>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>;
>
> According to the Hardware User Manual 0.80, V3H does not have the Stream
> Buffer (second region).
Indeed, I forgot to check the manual. TY for noticing!
>> + phy-mode = "rgmii-id";
>
> This is different from H3, M3-W, and D3. Care to elaborate for the layman
> in me?
See Documentation/devicetree/bindings/net/ethernet.txt, I don't know anything beyond that anyway. :-)
Based on the manual, I'd think we should use "rgmii" here and override it in the board DT if needed...
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
