Hi Sergei, On Fri, Feb 2, 2018 at 7:39 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > Describe [H]SCIF ports in the R8A77980 device tree. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi > @@ -85,6 +92,150 @@ > #power-domain-cells = <1>; > }; > > + hscif0: serial@e6540000 { > + compatible = "renesas,hscif-r8a77980", > + "renesas,rcar-gen3-hscif", > + "renesas,hscif"; > + reg = <0 0xe6540000 0 0x60>; > + interrupts = <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 520>, > + <&cpg CPG_CORE 16>, Shouldn't this be 19 (S3D1) instead of 16 (S2D1)? With that fixed (for all (H)SCIF ports); Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds