On Mon, Jan 22, 2018 at 07:23:00PM +0100, Marcel Holtmann wrote: > Hi Rob, > > > Adds serdev_device_set_parity() and an implementation for ttyport. > > The interface uses an enum with the values SERIAL_PARITY_NONE, > > SERIAL_PARITY_EVEN and SERIAL_PARITY_ODD. > > > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> > > Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx> > > --- > > > > Hi! > > > > This revision addresses Johan's comments (see below for details) and adds > > Sebastian's Reviewed-by tag. Thank you for your reviews! > > > > CU > > Uli > > > > > > Changes since v1: > > - added Reviewed-by tag > > - expanded commit message > > - shuffled stuff around to keep line-setting bits together > > - clear CMSPAR > > - (hopefully) detect errors correctly by checking tty->termios after call > > to tty_set_termios(). > > > > > > drivers/tty/serdev/core.c | 12 ++++++++++++ > > drivers/tty/serdev/serdev-ttyport.c | 24 ++++++++++++++++++++++++ > > include/linux/serdev.h | 10 ++++++++++ > > 3 files changed, 46 insertions(+) > > if there are no objections, I would like to just take this through bluetooth-next tree. Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>