On 21/01/18 11:21, Hans Verkuil wrote:
> On 21/01/18 10:53, jacopo mondi wrote:
>> Hi Hans,
>>
>> On Fri, Jan 19, 2018 at 12:20:19PM +0100, Hans Verkuil wrote:
>>> static int ov7670_g_parm(struct v4l2_subdev *sd, struct v4l2_streamparm *parms)
>>> {
>>> struct v4l2_captureparm *cp = &parms->parm.capture;
>>> struct ov7670_info *info = to_state(sd);
>>>
>>> if (parms->type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
>>> return -EINVAL;
>>>
>>> And parms->type is CAPTURE_MPLANE. Just drop this test from the ov7670 driver
>>> in the g/s_parm functions. It shouldn't test for that since a subdev driver
>>> knows nothing about buffer types.
>>>
>>
>> I will drop that test in an additional patch part of next iteration of this series,
>
> Replace g/s_parm by g/s_frame_interval. Consider g/s_parm for subdev drivers as
> deprecated (I'm working on a patch series to replace all g/s_parm uses by
> g/s_frame_interval).
Take a look here:
https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=parm
You probably want to use the patch 'v4l2-common: add g/s_parm helper functions'
for the new ceu driver in your patch series. Feel free to add it.
Regards,
Hans
