On Wednesday, January 17, 2018 11:19:17 AM CET Vinod Koul wrote: > On Wed, Jan 17, 2018 at 10:38:28AM +0100, Geert Uytterhoeven wrote: > > The current (empty) system sleep callbacks rely on the PM core to force > > a runtime resume to reinitialize the DMAC registers during system > > resume. Without a reinitialization, e.g. SCIF DMA will hang silently > > after a system resume on R-Car Gen3. > > > > Make this explicit by using pm_runtime_force_{suspend,resume}() as the > > system sleep callbacks instead. Use SET_LATE_SYSTEM_SLEEP_PM_OPS() as > > DMA engines must be initialized before all DMA slave devices. > > > > Suggested-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > --- > > This is a dependency for "[PATCH 1/2] PM / genpd: Stop/start devices > > without pm_runtime_force_suspend/resume()" > > (https://www.spinics.net/lists/kernel/msg2696802.html), so perhaps it > > makes most sense if Rafael takes it through the PM tree? > > Sounds okay to me. > > Acked-By: Vinod Koul <vinod.koul@xxxxxxxxx> OK, so I'll take it. Thanks!