Re: [PATCH v2 04/12] drm: rcar-du: Convert LVDS encoder code to bridge driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/15/2018 11:32 PM, Laurent Pinchart wrote:

The LVDS encoders used to be described in DT as part of the DU. They now
have their own DT node, linked to the DU using the OF graph bindings.
This allows moving internal LVDS encoder support to a separate driver
modelled as a DRM bridge. Backward compatibility is retained as legacy
DT is patched live to move to the new bindings.

Signed-off-by: Laurent Pinchart
<laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>

[...]

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 6e02c762a557..06a3fbdd728a
100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c

[...]

   /* --------------------------------------------------------------------
@@ -74,7 +75,6 @@ static const struct rcar_du_device_info
rzg1_du_r8a7745_info = {
   			.port = 1,
  >   		},
   	},
-	.num_lvds = 0,
   };
static const struct rcar_du_device_info rcar_du_r8a7779_info = {
@@ -95,14 +95,13 @@ static const struct rcar_du_device_info
rcar_du_r8a7779_info = {
   			.port = 1,
   		},
   	},
-	.num_lvds = 0,
   };
static const struct rcar_du_device_info rcar_du_r8a7790_info = {
   	.gen = 2,
   	.features = RCAR_DU_FEATURE_CRTC_IRQ_CLOCK
   		  | RCAR_DU_FEATURE_EXT_CTRL_REGS,
-	.quirks = RCAR_DU_QUIRK_ALIGN_128B | RCAR_DU_QUIRK_LVDS_LANES,
+	.quirks = RCAR_DU_QUIRK_ALIGN_128B,
   	.num_crtcs = 3,
   	.routes = {
   		/*
@@ -164,7 +163,6 @@ static const struct rcar_du_device_info
rcar_du_r8a7792_info = {
   			.port = 1,
   		},
   	},
-	.num_lvds = 0,
   };
static const struct rcar_du_device_info rcar_du_r8a7794_info = {
@@ -186,7 +184,6 @@ static const struct rcar_du_device_info
rcar_du_r8a7794_info = {
   			.port = 1,
   		},
   	},
-	.num_lvds = 0,

I think you can remove *all* such initializers and the field itself with
them -- otherwise it looks like you're doing a not-quite-related drive-by
clean up...

The OF compatibility code uses the .num_lvds field, that's why I haven't
removed it.

Ah, I haven't yet reviewed that patch! But then I would leave the initializers alone...

MBR, Sergei



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux