Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

On Fri, Jan 5, 2018 at 11:46 PM, Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote:
> This series adds RZ/A1 gadget support to the renesas_usbhs driver.
> Basically, it's almost the same HW as the R-Car (and SH) parts.
> The only real difference is the some extra registers for the PHY.
>
> This was tested on an RSK board by connecting to a PC as an
> Ethernet CDC gadget.
>
> v3:
>  * Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs"
>  * Removed "renesas,usbhs-r7s72100"
>  * Changed License of rza.c

Thanks for the update, but I think there has been a misunderstanding.
I didn't mean to drop "renesas,usbhs-r7s72100" everywhere, only from
the matching in the driver.

Summarized:
1. DT bindings should document _all_ compatible values (SoC-specific,
   and/or family-specific, generic, ...),
2. DTS should list _all applicable_ compatible values, ordered from
    most-specific to least-specific,
3. Drivers should match against the least-specific compatible value to get
   the job done.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux