Hi Wolfram, On Thu, Dec 14, 2017 at 11:30 PM, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > Make it possible to fallback to GPIO for I2C4 on the EXIO-E connector. > > This is based on reference work for the I2C0 core of the lager/r8a7790 > by Wolfram Sang. > > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > [wsa: rebased, fixed aliases, switched to named GPIOS] > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -480,6 +504,11 @@ > function = "i2c2"; > }; > > + i2c4_pins: i2c4 { > + groups = "i2c4"; > + function = "i2c4"; > + }; This change breaks VIN: -rcar-vin e6ef0000.video: Device registered as video25 +sh-pfc e6060000.pin-controller: pin GP_4_13 already requested by e6520000.i2c; cannot claim for e6ef0000.video +sh-pfc e6060000.pin-controller: pin-141 (e6ef0000.video) status -22 +sh-pfc e6060000.pin-controller: could not request pin 141 (GP_4_13) from group vin0_data24 on device sh-pfc +rcar-vin e6ef0000.video: Error applying setting, reverse things back +rcar-vin: probe of e6ef0000.video failed with error -22 I2C4 on Koelsch uses pins GP7_13/14 (group "i2c4_c"), not GP4_13/14 (group "i2c4"). Fixing it up in today's renesas-drivers release. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds