Re: [PATCH] arm64: dts: renesas: salvator-common: add GPIO extender

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sergei,

On Thu, Dec 21, 2017 at 5:07 PM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> On 12/21/2017 03:25 PM, Geert Uytterhoeven wrote:
>>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>>> @@ -338,6 +338,11 @@
>>>   &i2c4 {
>>>          status = "okay";
>>>
>>> +       pca9654: gpio@20 {
>>> +               compatible = "onsemi,pca9654";
>>> +               reg = <0x20>;
>>
>>
>> Missing gpio-controller, #gpio-cells, and interrupts properties?
>
>    Indeed.
>
>> Seems like Documentation/devicetree/bindings/gpio/gpio-pca953x.txt
>> can use some updates...
>
>    What do you mean? I've surely updated it in my vendor prefix fix:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8a64e557f399090f5d1917b2f32a065da2b12be1

I mean the missing properties are also not documented in the bindings,
or omitted in the example.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux