On 21 December 2017 at 02:43, Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote: > On Fri, Dec 15, 2017 at 4:56 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: >> The PM core in the device_prepare() phase, resets the wakeup_path status >> flag to the value of device_may_wakeup(). This means if a ->prepare() or a >> ->suspend() callback for the device would update the device's wakeup >> setting, this doesn't become reflected in the wakeup_path status flag. >> >> In general this isn't a problem, because wakeup settings isn't supposed to >> be changed during those system suspend phases. Nevertheless, there are a >> cases not conforming to that behaviour, as device_set_wakeup_enable() is >> indeed called from ->suspend() callbacks. > > And why is this regarded as correct? I am not saying that this behavior is correct. However, I am trying to improve the situation, which doesn't hurt or does it? More importantly, the next patch, which is about the wakeup path, depends on this. Kind regards Uffe
