Hi Simon, On Wed, Dec 20, 2017 at 11:23 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Mon, Dec 18, 2017 at 12:22:17PM +0100, Geert Uytterhoeven wrote: >> On Thu, Dec 14, 2017 at 3:11 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: >> > On 9 November 2017 at 14:27, Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote: >> >> If an R-Car SYSC slave device is part of the CPG/MSTP or CPG/MSSR Clock >> >> Domain and to be used as a wakeup source, it must be kept active during >> >> system suspend. >> >> >> >> Currently this is handled in device-specific drivers by explicitly >> >> increasing the use count of the module clock when the device is >> >> configured as a wakeup source. However, the proper way to prevent the >> >> device from being stopped is to inform this requirement to the genpd >> >> core, by setting the GENPD_FLAG_ACTIVE_WAKEUP flag. >> >> >> >> Note that this will only affect devices configured as wakeup sources. >> >> >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> > >> > Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> >> >> Thank you! >> >> Simon: can you please queue this up for v4.16? >> I have queued the other 2 clock patches in clk-renesas-for-v4.16, and sent >> a PR for it. > > Thanks, I have applied this patch to the soc-for-v4.16 branch. > It is currently not based v4.15-rc1. Let me know if it should > be rebased on top of your pull request for clk-renesas-for-v4.16. If the base is not v4.15-rc1, what is it? GENPD_FLAG_ACTIVE_WAKEUP was introduced in v4.15-rc1, so it won't compile based on v4.14. There's no dependency on the clock drivers, so no need to base on top of clk-renesas-for-v4.16. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds