Hi Fabrizio, On Tue, Dec 19, 2017 at 12:37 PM, Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> wrote: >> Subject: Re: [PATCH v2 3/6] ARM: dts: r8a7743: Add PWM SoC support >> >> On Mon, Dec 18, 2017 at 6:52 PM, Fabrizio Castro >> <fabrizio.castro@xxxxxxxxxxxxxx> wrote: >> > Add the definitions for pwm[0123456] to the SoC .dtsi. >> > >> > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> >> > Reviewed-by: Biju Das <biju.das@xxxxxxxxxxxxxx> >> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> >> > --- a/arch/arm/boot/dts/r8a7743.dtsi >> > +++ b/arch/arm/boot/dts/r8a7743.dtsi >> > @@ -1082,6 +1082,83 @@ >> > status = "disabled"; >> > }; >> > >> > + pwm0: pwm@e6e30000 { >> > + compatible = "renesas,pwm-r8a7743", >> > + "renesas,pwm-rcar"; >> >> I think the above can fit in one line. > > do you think this deserves a v3? That depends on the fuzziness-acceptance level of Simon... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds