Hi Rob, Thank you for your comments! > -----Original Message----- > From: Rob Herring, Sent: Sunday, December 17, 2017 3:05 AM > > On Fri, Dec 15, 2017 at 02:45:26PM +0900, Yoshihiro Shimoda wrote: > > Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS > > and ID. So, they may be connected to gpio pins. To handle the gpio > > pins, this patch adds the handling of VBUS and ID pins instead of > > dedicated pins. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > --- > > .../devicetree/bindings/phy/rcar-gen3-phy-usb2.txt | 2 + > > drivers/phy/renesas/phy-rcar-gen3-usb2.c | 77 ++++++++++++++++++++-- > > 2 files changed, 72 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > index 99b651b..999a6ef 100644 > > --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt > > @@ -27,6 +27,8 @@ channel as USB OTG: > > - interrupts: interrupt specifier for the PHY. > > - vbus-supply: Phandle to a regulator that provides power to the VBUS. This > > regulator will be managed during the PHY power on/off sequence. > > +- vbus-gpios: use gpio to control vbus instead of dedicated pin. > > How does this relate to vbus-supply? A gpio-regulator doesn't work here? Thank you for the pointed out. You're correct. A gpio-regulator can work intead of "vbus-gpios". So, I will drop this. > > +- id-gpios: use gpio to detect id instead of dedicated pin. > > These aren't part of the phy, but really belong in a connector node. I'm afraid but I don't understand "a connector node" mean. Is it an extcon device for instance? If so, I'll try to use extcon-usb-gpio.c instead of own gpio handling on the driver. Best regards, Yoshihiro Shimoda > Rob
