On Tue, Dec 12, 2017 at 11:42 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>> Documentation/gpio/consumer.txt | 14 +++++++++++---
>
> You need to fix the kerneldoc for 'gpiod_get_direction", too. It still
> mentions GPIOF_DIR_*.
More places? I can't find them!
I thought the patch removed that here:
-This function will return either GPIOF_DIR_IN or GPIOF_DIR_OUT.
+This function will return either 1 (input) or 0 (output). There are also
+these convenience helpers:
I can only find it in Documentation/gpio/gpio-legacy.txt which is
fine.
>> +static inline bool gpiod_is_input(struct gpio_desc *desc)
>> +{
>> + int ret = gpiod_get_direction(desc);
>> + if (ret < 0) {
>> + pr_err("GPIO: failed to get direction\n");
>
> Is that really helpful for the user if we don't say which GPIO failed?
I would have to add yet more APIs to do that.
Hm.
Together with Geert's comments I start to lean towards actually
just creating two new #defines in <linux/consumer.h>.
It has the upside that we can also check the return value
for errors.
Yours,
Linus Walleij
