Re: [PATCH] net: sh_eth: do not advertise Gigabit capabilities when not available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/04/2017 05:13 PM, Thomas Petazzoni wrote:

Not all variants of the sh_eth hardware have Gigabit
support. Unfortunately, the current driver doesn't update
phydev->supported depending on the MAC capabilities. Due to this, if
you have a Gigabit capable PHY, the PHY will advertise its Gigabit
capability and establish a link at 1Gbit/s, even though the MAC
doesn't support it.

In order to avoid this, we mark phydev->supported if we're running a
non-Gigabit capable hardware.

Tested on a SH7786 platform, with a Gigabit PHY.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
---
  drivers/net/ethernet/renesas/sh_eth.c | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index db72d13cebb9..0074c5998481 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -1892,6 +1892,11 @@ static int sh_eth_phy_init(struct net_device *ndev)
  		return PTR_ERR(phydev);
  	}
+ /* mask with MAC supported features */
+	if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
+		phydev->supported &= PHY_BASIC_FEATURES;
+	phydev->advertising = phydev->supported;
+

Um, looking at this again, I think we have phy_set_max_speed() for that kind of stuff now...

[...]

MBR, Sergei



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux