Re: [PATCH/RFC 5/5] ARM: shmobile: defconfig: Disable CONFIG_EMBEDDED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

On Fri, Dec 1, 2017 at 9:33 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote:
> On Thu, Nov 30, 2017 at 02:12:02PM +0100, Geert Uytterhoeven wrote:
>> CONFIG_EXPERT exposes too many config options that do not matter for
>> development. However, CONFIG_EMBEDDED selects CONFIG_EXPERT, so it
>> cannot be disabled.
>>
>> Hence disable CONFIG_EMBEDDED, and compensate for the loss of
>> CONFIG_DEBUG_KERNEL by enabling the latter.
>>
>> Actual impact:
>>   - CONFIG_NAMESPACES=y,
>>   - CONFIG_SYSCTL_SYSCALL=n,
>>   - CONFIG_SERIAL_SH_SCI_NR_UARTS changed from 20 to 18,
>>   - CONFIG_SERIAL_SH_SCI_EARLYCON=y,
>>   - Some HID support became enabled,
>>   - CONFIG_DEBUG_MEMORY_INIT=y,
>>
>> Refresh the result.
>
> I'm sorry but I don't understand the motivation for this change.
> I understand that it might make the image smaller or build times faster.
> But it seems to be a risky change for those benefits.

My main motivation is to start using the default values for the various SH_SCI
options from the first 4 patches, but that requires disabling CONFIG_EXPERT.
Sorry for not making that clearer.

> What are the side-effects of the changes you describe above?

Enabling CONFIG_NAMESPACES shouldn't hurt (isn't that also needed for
systemd anyway?), just like the HID devices, or CONFIG_DEBUG_MEMORY_INIT
(it does a few more checks, and defaults to yes).

Disabling CONFIG_SYSCTL_SYSCALL also shouldn't hurt (it defaults to no),
except for very old userland not yet using /proc/sys, which might have been
broken along the way by changed binary paths anyway.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux