On Thu, Nov 30, 2017 at 12:57:00PM +0100, Geert Uytterhoeven wrote: > From: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > > The Kconfig currently controlling compilation of this code is: > > config SIMPLE_PM_BUS > bool "Simple Power-Managed Bus Driver" > > ...meaning that it currently is not being built as a module by anyone. > > In removing the orphaned modular support in a previous patch set, > Geert indicated he'd rather see this code converted to tristate. > > I normally don't do that because it extends functionality that I > can't easily run time test or even know if the use case makes sense, > but since in this case the author has nominated it as such, we do > the conversion here. > > Note that doesn't change the lack of run time testing ; this change > is only tested for sucessful compile and modpost. > > [geert: Ethernet is probed successfully on sh73a0/kzm9g after > insmodding simple-pm-bus.ko] > > Cc: Kevin Hilman <khilman@xxxxxxxxxx> > Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Acked-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > --- > drivers/bus/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index dc7b3c7b7d42fd09..57e011d36a79fce3 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -120,7 +120,7 @@ config QCOM_EBI2 > SRAM, ethernet adapters, FPGAs and LCD displays. > > config SIMPLE_PM_BUS > - bool "Simple Power-Managed Bus Driver" > + tristate "Simple Power-Managed Bus Driver" > depends on OF && PM > help > Driver for transparent busses that don't need a real driver, but > -- > 2.7.4 >