Hi Kieran,
Thanks for your patch. I will squash this in with the original patch.
This was a left over from moving the video device registration from
probe() to the async callbacks.
On 2017-11-30 14:59:04 +0000, Kieran Bingham wrote:
> From: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
>
> rvin_group_init incorrectly calls rvin_group_update_links.
>
> Repair by removing the call, and simply returning 0;
>
> Fixes: 3135326aae2c ("rcar-vin: parse Gen3 OF and setup media graph")
> Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> ---
> Hi Niklas,
>
> A small fixup for your RCar VIN branch
>
> drivers/media/platform/rcar-vin/rcar-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c
> index be2dfe2908e0..924722a0fdfa 100644
> --- a/drivers/media/platform/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> @@ -926,7 +926,7 @@ static int rvin_group_init(struct rvin_dev *vin)
> goto error_vdev;
> }
>
> - return rvin_group_update_links(vin);
> + return 0;
>
> error_vdev:
> rvin_v4l2_unregister(vin);
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
