On Fri, Nov 17, 2017 at 01:47:04PM +0300, Sergei Shtylyov wrote:
> On 11/17/2017 12:06 PM, Geert Uytterhoeven wrote:
>
> > > Despite commit 55020c8056a8 ("of: Add vendor prefix for ON Semiconductor
> > > Corp.") was made long ago, the latter commit 9f49f6dd0473 ("gpio: pca953x:
> > > add onsemi,pca9654 id") made use of another, undocumented vendor prefix.
> >
> > Ouch...
> >
> > > Since such prefix doesn't seem to be used in any device trees, I think we
> > > can just fix the "compatible" string in the driver and the bindings and be
> > > done with that...
> > >
> > > Fixes: 9f49f6dd0473 ("gpio: pca953x: add onsemi,pca9654 id")
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> > >
> > > ---
> > > The patch is against the 'fixes' branch of LinusW's 'linux-gpio.git' repo.
> > >
> > > Documentation/devicetree/bindings/gpio/gpio-pca953x.txt | 2 +-
> > > drivers/gpio/gpio-pca953x.c | 2 +-
> >
> > There's another (different) one in
> > Documentation/devicetree/bindings/misc/idt_89hpesx.txt
>
> Saw that. Do you think it also should be fixed (in this patch)?
IMO, separate.
