On Fri, Nov 17, 2017 at 06:32:19AM -0800, Simon Horman wrote:
> On Thu, Nov 16, 2017 at 10:31:31AM +0100, Geert Uytterhoeven wrote:
> > Hi Uli,
> >
> > On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht
> > <ulrich.hecht+renesas@xxxxxxxxx> wrote:
> > > No devices to add, I2C1 has an external connector only.
> > >
> > > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > but please see below.
>
> Thanks, applied.
Sorry, I was a bit hasty there as this patch
depends on a patch earlier in the series which I have not applied.
I've dropped this patch for now and will wait a bit longer for the review
to unfold.
> > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> >
> > > @@ -84,6 +89,12 @@
> > > };
> > > };
> > >
> > > +&i2c1 {
> > > + pinctrl-0 = <&i2c1_pins>;
> > > + pinctrl-names = "default";
> > > + status = "okay";
> >
> > If no devices are connected, perhaps it's wise to defer the status update
> > to e.g. an overlay that describes what's connected to CN23?
> >
> > Or do you want it enabled to allow adding devices manually using
> > /sys/bus/i2c/devices/i2c-1/new_device?
>
> Ulrich, please consider following up on this.
>
