On Thu, Nov 16, 2017 at 10:10:27AM +0100, Geert Uytterhoeven wrote:
> Hi Ulrich,
>
> On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht
> <ulrich.hecht+renesas@xxxxxxxxx> wrote:
> > Defines R-Car D3 I2C controllers 0-3.
> >
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi
> > @@ -400,6 +400,70 @@
> > status = "disabled";
> > };
> >
> > + i2c0: i2c@e6500000 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "renesas,i2c-r8a77995",
> > + "renesas,rcar-gen3-i2c";
> > + reg = <0 0xe6500000 0 0x40>;
> > + interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 931>;
> > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>;
> > + resets = <&cpg 931>;
> > + dmas = <&dmac1 0x91>, <&dmac1 0x90>;
> > + dma-names = "tx", "rx";
>
> Missing set for dmac2? (for all four interfaces)
>
> > + i2c-scl-internal-delay-ns = <110>;
>
> According to Table 57.1, all i2c interfaces on R-Car D3 have LVTTL
> output buffers,
> so this should be <6> for all four interfaces.
>
> With the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Hi Ulrich,
I would like Geert's review addressed before I consider applying this patch.
