Re: [PATCH v2 1/7] arm64: dts: renesas: r8a7796: Add IPMMU device nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

On Fri, Nov 10, 2017 at 2:26 PM, Simon Horman
<horms+renesas@xxxxxxxxxxxx> wrote:
> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
>
> Add r8a7796 IPMMU nodes and keep all disabled by default.
>
> Signed-off-by: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
> Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> ---
> v2 [Simon Horman]
> * Drop mostly redundant comments from nodes
> * Add power domains

Thanks for the update!

With the below fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi

[...]

> +               ipmmu_vc0: mmu@fe6b0000 {
> +                       compatible = "renesas,ipmmu-r8a7796";
> +                       reg = <0 0xfe6b0000 0 0x1000>;
> +                       renesas,ipmmu-main = <&ipmmu_mm 8>;
> +                       power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;

R8A7796_PD_A3VC

> +                       #iommu-cells = <1>;
> +                       status = "disabled";
> +               };

[...]

> +               ipmmu_ds0: mmu@e6740000 {
> +                       compatible = "renesas,ipmmu-r8a7796";
> +                       reg = <0 0xe6740000 0 0x1000>;
> +                       renesas,ipmmu-main = <&ipmmu_mm 0>;

power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;

> +                       #iommu-cells = <1>;
> +                       status = "disabled";
> +               };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux