On Mon, Oct 09, 2017 at 01:45:07PM +0000, Fabrizio Castro wrote:
> Hello Geert,
>
> thank you for your feedback!
>
> >
> > Hi Fabrizio, Chris,
> >
> > On Mon, Oct 9, 2017 at 11:06 AM, Fabrizio Castro
> > <fabrizio.castro@xxxxxxxxxxxxxx> wrote:
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > > Signed-off-by: Chris Paterson <chris.paterson2@xxxxxxxxxxx>
> >
> > Thanks for your patch!
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> >
> > > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> > > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> > > @@ -11,6 +11,7 @@
> > > / {
> > > aliases {
> > > serial0 = &scif0;
> > > + serial3 = &scifb1;
> >
> > Given this port is not labeled "serial3", but called "data uart", you may want
> > to add a comment to avoid confusion:
>
> It's a little bit confusing, isn't it? The lines related to such
> interface are named as UART0_x on the carrier board schematic, the
> section of the schematic that contains the header is named "data uart
> header", and the board documentation names it explicitly as "UART 3 -
> /dev/ttySC3 (SCIFB1)".
>
> I don't think there is anything we can do to make this easier for the
> user really, is there? :D If we decide to add a comment to serial 3, I
> guess we need to be consistent and add comments for the other serial
> interfaces too. If you still prefer having a comment there I'll send a
> v2 and patch(es) for adding comments to the other interfaces, just let me
> know.
I have applied this patch. If a comment is subsequently decided on
then please send a follow-up patch.
