On 16 October 2017 at 15:55, Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote: > Hi all, > > If a device in a Renesas ARM SoC is part of a Clock Domain, and it is > used as a wakeup source, it must be kept active during system suspend. > > Currently this is handled in device-specific drivers by explicitly > increasing the use count of the module clock when the device is > configured as a wakeup source. However, the proper way to prevent the > device from being stopped is to inform this requirement to the genpd > core. Hence this series does that, so the workarounds can be removed. > > This patch series consist of 4 parts: > 1. Patches 1-3 fix the clk-renesas-mstp, clk-renesas-cpg-mssr, and > rcar-sysc Clock and/or PM Domain drivers by providing > gpd_dev_ops.active_wakeup() callbacks, As we spoked about at ELC yesterday, I think the genpd specific callback for dealing with this is not really the proper solution. Instead I think this should be treated as a generic problem. In principle I think we need a way for drivers to inform the middle-layer/genpd about wakeup requirements during system-wide PM. Allow me to post a patch showing what I had in mind, then we can see what you think about it. > > 2. Patch 4 adds a new GENPD_FLAG_ACTIVE_WAKEUP flag, to avoid various > PM Domain drivers that need similar behavior having to provide > their own identical .active_wakeup() callbacks, This makes sense, however I think it's sufficient to make genpd check the flag, rather than assigning and using the ->active_wakeup() callback. That would then make it possible to remove the callback altogether. Can you do that instead? [...] Kind regards Uffe
