Hi Geert, today, I want to learn some history ;) On 12.11.2015 16:54, Geert Uytterhoeven wrote:
Add a new R-Car H3 Clock Pulse Generator / Module Standby and Software Reset driver, using the new CPG/MSSR driver core. Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> ---
...
diff --git a/drivers/clk/shmobile/r8a7795-cpg-mssr.c b/drivers/clk/shmobile/r8a7795-cpg-mssr.c new file mode 100644 index 0000000000000000..57c413635d1af135 --- /dev/null +++ b/drivers/clk/shmobile/r8a7795-cpg-mssr.c
...
+static const struct cpg_core_clk r8a7795_core_clks[] __initconst = { + /* External Clock Inputs */ + DEF_INPUT("extal", CLK_EXTAL), + DEF_INPUT("extalr", CLK_EXTALR),
Why do we read the extal* frequencies from DT and don't auto detect them based on the MD pins?
Yesterday, I spent two hours debugging a clock issue due to a wrong DT because the hardware guys populated a different EXTAL oscillator. I would have saved this time if it would have been auto detected.
Best regards Dirk