RE: [PATCH] ARM: dts: iwg20d-q7: Add support for ttySC3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Geert,

> >
> > > --- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> > > +++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
> > > @@ -11,6 +11,7 @@
> > >  / {
> > >         aliases {
> > >                 serial0 = &scif0;
> > > +               serial3 = &scifb1;
> >
> > Given this port is not labeled "serial3", but called "data uart", you may want
> > to add a comment to avoid confusion:
>
> It's a little bit confusing, isn't it? The lines related to such interface are named as UART0_x on the carrier board schematic, the section
> of the schematic that contains the header is named "data uart header", and the board documentation names it explicitly as "UART 3 -
> /dev/ttySC3 (SCIFB1)".
>
> I don't think there is anything we can do to make this easier for the user really, is there? :D
> If we decide to add a comment to serial 3, I guess we need to be consistent and add comments for the other serial interfaces too.
> If you still prefer having a comment there I'll send a v2 and patch(es) for adding comments to the other interfaces, just let me know.

Any thoughts about this?

Thanks,
Fab

>
> Thanks,
> Fab
>



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux