Hi Sergei,
On Mon, Oct 16, 2017 at 10:17 PM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> On 10/16/2017 04:55 PM, Geert Uytterhoeven wrote:
>> Currently, if Wake-on-LAN is enabled, the EtherAVB device's module clock
>> is manually kept running during system suspend, to make sure the device
>> stays active.
>>
>> Since "soc: renesas: rcar-sysc: Keep wakeup sources active during system
>> suspend", this workaround is no longer needed. Hence remove all
>> explicit clock handling to keep the device active.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> [...]
>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
>> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
>> b/drivers/net/ethernet/renesas/ravb_main.c
>> index fdf30bfa403bf416..11ffccca11d56df5 100644
>> --- a/drivers/net/ethernet/renesas/ravb_main.c
>> +++ b/drivers/net/ethernet/renesas/ravb_main.c
>
> [...]
>>
>> @@ -2289,8 +2283,6 @@ static int __maybe_unused ravb_resume(struct device
>> *dev)
>> * this clock dance should be removed.
>> */
>> clk_disable(priv->clk);
>> - clk_disable(priv->clk);
>> - clk_enable(priv->clk);
>> clk_enable(priv->clk);
>
>
> I thought the entire clock dance could be removed now? Not yet?
The remaining clock dance steps work around PSCI powering down the SoC,
after which the hardware and Linux disagree about the clock state.
They can be removed after "[PATCH v3 0/5] clk: renesas: rcar-gen3: Restore
clocks during resume" has hit upstream.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
