RE: [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Biju-san,

IIUC, when we submitted a patch for dts[i] file,
we don't need to submit such a patch to usb maintainers.

> From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> 
> From: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> 
> Add node for xhci. Boards DT files will enable it if needed.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/r8a7743.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index 699c040..386bf07 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -931,6 +931,26 @@
>  			status = "disabled";
>  		};
> 
> +		/*
> +		 * pci1 and xhci share the same phy, therefore only one of them
> +		 * can be active at any one time. If both of them are enabled,
> +		 * a race condition will determine who'll control the phy.
> +		 * A firmware file is needed by the xhci driver in order for
> +		 * USB 3.0 to work properly.
> +		 */
> +		xhci: usb@ee000000 {
> +			compatible = "renesas,xhci-r8a7743",
> +				     "renesas,rcar-gen2-xhci";
> +			reg = <0 0xee000000 0 0xc00>;
> +			interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 328>;
> +			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> +			resets = <&cpg 328>;
> +			phys = <&usb2 1>;
> +			phy-names = "usb";
> +			status = "disabled";
> +		};
> +
>  		sdhi0: sd@ee100000 {
>  			compatible = "renesas,sdhi-r8a7743";
>  			reg = <0 0xee100000 0 0x328>;

It seems good to me. So,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>

Best regards,
Yoshihiro Shimoda

> --
> 1.9.1





[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux