On Fri, Oct 13, 2017 at 8:23 PM, Robin Murphy <robin.murphy@xxxxxxx> wrote: > Arnd reports a build warning[1] thanks to me missing ipmmu-vmsa's second > set of ops when converting io-pgtable-arm users to the new iommu_iotlb_* > callbacks. Rather than just treat the symptom with a point fix, this > seemed like a good excuse to clean up the messy #ifdeffery and > duplication in the driver that led to the oversight in the first place. > > Build-tested successfully for arm64, ARM, and ARM + CONFIG_IOMMU_DMA. Very nice. I looked over the patches and while I only understood half of what you do and why it was different to start with, I very much welcome the end result. Arnd