Hi Simon, On Fri, Oct 13, 2017 at 1:05 PM, Simon Horman <horms+renesas@xxxxxxxxxxxx> wrote: > Use newly added R-Car GPIO Gen1 fallback compat string > in place of now deprecated non-generation specific > R-Car GPIO fallback compat string in DT of r8a7779 SoC. > > As the driver does not match on "renesas,gpio-r8a7779" there > are some run-time considerations for this patch: > > * When a resulting DTB is used with kernels newer than v4.14 this should > not have any run-time effect as renesas,rcar-gen2-gpio is matched by the gen1 > driver since commit dbd1dad2ab8f ("gpio: rcar: add gen[123] fallback > compatibility strings") > > * However, when used with older kernels GPIO will be disabled as > no compat string match will be made by the driver. > > The regression documented above for the new DTB with old kernel case > is acceptable in my opinion. > > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> Apart from that: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds