Re: [PATCH] pinctrl: sh-pfc: r8a7795: Add HSCIF pins, groups, and functions

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Wolfram,

On Fri, Oct 6, 2017 at 12:37 PM, Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> Tested on a Salvator-XS with HSCIF1 mapped to debug1 connector with this
> snipplet in salvator-common.dtsi:

Thanks for your patch (and for testing ;-)!

> I verified to the best of my knowledge that all the other settings are equal to
> r8a7795-es1.

Unfortunately you missed that ES2.0 has a third set of pins for HSCIF2.
Can you please add these, too?
The rest looks fine to me.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds