> -----Original Message----- > From: geert.uytterhoeven@xxxxxxxxx [mailto:geert.uytterhoeven@xxxxxxxxx] > On Behalf Of Geert Uytterhoeven > Sent: 06 October 2017 08:36 > To: Biju Das <biju.das@xxxxxxxxxxxxxx> > Cc: Vinod Koul <vinod.koul@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; > Mark Rutland <mark.rutland@xxxxxxx>; Simon Horman > <horms@xxxxxxxxxxxx>; Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>; > Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>; > devicetree@xxxxxxxxxxxxxxx; Linux-Renesas <linux-renesas- > soc@xxxxxxxxxxxxxxx>; dmaengine@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] dmaengine: usb-dmac: Add compatible string for > r8a7743/5 > > Hi Biju, > > On Thu, Oct 5, 2017 at 5:19 PM, Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > > This patch adds support for r8a7743/5 SoC. The Renesas RZ/G1[ME] > > (R8A7743/5) usbdmac engine is identical to the R-Car Gen2 family. > > > > This doesn't change the driver, so it does nothing by itself. But it > > does > > Wording it like this may give the wrong impression to the casual reader that a > driver change will be submitted separately. > No driver change is needed due to the fallback compatible value "renesas,usb- > dmac". > > > mean that checkpatch won't complain about a future patch that adds > > "renesas,r8a7743-usb-dmac" or "renesas,r8a7745-usb-dmac" to a DT, > > which helps ensure that shipped DTs use documented compatibility strings. > > Adding the SoC-specific compatible values here has two purposes: > 1. Document which SoCs have this hardware module, > 2. Allow checkpatch to validate compatible values. Thanks. I will send v2 with above changes > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
