Hi Geert,
On Wednesday, 4 October 2017 13:40:13 EEST Laurent Pinchart wrote:
> On Wednesday, 4 October 2017 12:07:04 EEST Geert Uytterhoeven wrote:
> > Move R-Car H3 ES1.x bias support over to the generic way to describe
> > bias registers, which will be needed for suspend/resume support.
> >
> > As the new description is more compact, this decreases kernel size by
> > ca. 304 bytes.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
One additional comment, please see below.
> > ---
> >
> > drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c | 499 ++++++++++++-------------
> > 1 file changed, 258 insertions(+), 241 deletions(-)
> >
> > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> > b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c index
> > 246d0de915feaffe..229192cf8e7430af 100644
> > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
> > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7795-es1.c
[snip]
> > +static const struct pinmux_bias_reg pinmux_bias_regs[] = {
[snip]
> > + { },
I would write it as { /* Sentinel */ } to make it more explicit that a last
zero entry is required.
> > };
[snip]
--
Regards,
Laurent Pinchart
