Hi Chris, On Tue, Oct 03, 2017 at 03:40:51PM +0000, Chris Brandt wrote: > Hi Jacopo, > > > Yes, that 'are' listed in the table. But for a good reason. > > The TIOC pins can be uses as an output (PWM for example) or as a input > (input capture for example), so they are not really a fixed direction. > That is why the user needs to specify how they plan to use them in the DT. > And...that's also why it doesn't make sense to put them in the > rza1l_swio_pins[] array (we have no idea how they want to use them). > > So, the hardware manual has the TIOC pins in the SWIO table to tell the > user 'hey, you have to manually set these pins to either input or output > yourself because we can't magically know what you want to use them for. > > But... > The reason for the rza1l_swio_pins[] array is for weird pin > configurations that are fixed (like LCD LVDS output pins need to be configured as > inputs). > > > > Thanks for double checking. Your source from Japan is more > > authoritative than manuals and defintely more accurate than me ;) > > So, after all that, I don't think we found any issues with my patch. > Correct??? Correct! :) After your clarification above, for both patches: Reviewed-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> Thanks j > > > Thanks! > > Chris >
