Re: [PATCH 22/48] ARM: dts: gr-peach: Add user led device nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 01, 2017 at 07:36:14PM +0200, jacopo mondi wrote:
> Hi Seregei,
> 
> On Sat, Sep 30, 2017 at 01:36:18PM +0300, Sergei Shtylyov wrote:
> > Hello!
> >
> > On 9/29/2017 2:53 PM, Simon Horman wrote:
> >
> > >From: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > >
> > >Add device nodes for user leds on gr-peach board.
> > >
> > >Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > >Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > >Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> > >---
> > >  arch/arm/boot/dts/r7s72100-gr-peach.dts | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > >
> > >diff --git a/arch/arm/boot/dts/r7s72100-gr-peach.dts b/arch/arm/boot/dts/r7s72100-gr-peach.dts
> > >index bcfa6445bbaa..13d745bb56a5 100644
> > >--- a/arch/arm/boot/dts/r7s72100-gr-peach.dts
> > >+++ b/arch/arm/boot/dts/r7s72100-gr-peach.dts
> > [...]
> > >@@ -51,6 +52,15 @@
> > >  			reg = <0x00600000 0x00200000>;
> > >  		};
> > >  	};
> > >+
> > >+leds {
> >
> >    Not indented properly...
> 
> Thanks!
> 
> Simon, as you sent pull request already, will we need a patch on top
> of this to fix it?

Thanks, please do.

I don't think we need to re-spin the pull-request to correct this,
rather, a follow-up patch can be provided in a follow-up pull-request.

> 
> Thanks
>   j
> >
> > >+		status = "okay";
> > >+		compatible = "gpio-leds";
> > >+
> > >+		led1 {
> > >+			gpios = <&port6 12 GPIO_ACTIVE_HIGH>;
> > >+		};
> > >+	};
> > >  };
> > >  &pinctrl {
> >
> > MBR, Sergei
> 



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux