Hi Mark, I am very sorry about the confusion. Geert has a good point so please drop this patch. Thanks, Fabrizio > -----Original Message----- > From: geert.uytterhoeven@xxxxxxxxx [mailto:geert.uytterhoeven@xxxxxxxxx] On Behalf Of Geert Uytterhoeven > Sent: 25 September 2017 20:16 > To: Mark Brown <broonie@xxxxxxxxxx> > Cc: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; > linux-spi <linux-spi@xxxxxxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; Linux-Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>; Chris > Paterson <Chris.Paterson2@xxxxxxxxxxx>; Biju Das <biju.das@xxxxxxxxxxxxxx> > Subject: Re: Applied "spi: sh-msiof: Add compatible strings for r8a774[35]" to the spi tree > > Hi Mark, > > On Mon, Sep 25, 2017 at 8:45 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Mon, Sep 25, 2017 at 07:48:44PM +0200, Geert Uytterhoeven wrote: > >> Please drop this patch, as there's no need to add explicit matching for these > >> compatible values. The family-specific compatible values (which the driver > >> already matches against) are sufficient. > > > > While the patch is not needed if people list the fallback property it > > also does no harm and provides a marginal documentation benefit in > > saying that someone has considered if any special handling is useful and > > decided that it isn't. > > All true. > > My rebuttal is threefold: > 1. Listing the fallback property is mandatory for new SoCs. We only keep > the per-SoC compatible values in the driver for older SoCs that predate > the introduction of fallback properties. > 2. Some harm is involved, in the form of increased kernel image size. > 3. When updating DT bindings for new SoCs, we usually add "No driver > update is needed" to the patch description to clarify. Unfortunately > that was missed here. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
