Hi Vladimir, On Thu, Sep 7, 2017 at 12:35 AM, Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> wrote: > Add M3ULCB Kingfisher Device tree bindings Documentation, listing it as a > supported board. > > Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/arm/shmobile.txt > +++ b/Documentation/devicetree/bindings/arm/shmobile.txt > @@ -85,6 +85,7 @@ Boards: > - Lager (RTP0RC7790SEB00010S) > compatible = "renesas,lager", "renesas,r8a7790" > - M3ULCB (R-Car Starter Kit Pro, RTP0RC7796SKBX0010SA09 (M3 ES1.0)) > + M3ULCB Kingfisher (SBEV-RCAR-KF-M03) As the Kingfisher is an extension board (and you added the same board part number to the H3ULCB section in patch 02/18), shouldn't it have its own compatible value "shimafuji,kingfisher" instead? Then this can be used in ulcb-kf.dtsi: compatible = "shimafuji,kingfisher"; and appended (overridden, as there's no /append-property/ directive in dtc yet?) in the board files, e.g. r8a7796-m3ulcb-kf.dts: compatible = "shimafuji,kingfisher", "renesas,m3ulcb", "renesas,r8a7796"; Does that make sense? > compatible = "renesas,m3ulcb", "renesas,r8a7796"; > - Marzen (R0P7779A00010S) > compatible = "renesas,marzen", "renesas,r8a7779" Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds