Hello!
On 09/06/2017 10:05 AM, Dirk Behme wrote:
From: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
When Tx DMA is only used, Tx FIFO is still not empty after DMA callback.
This patch waits for sweeping data out of the Tx FIFO.
Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
[adjust context]
Signed-off-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>
---
drivers/spi/spi-sh-msiof.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
index 660b03ed6770..a960e8da123d 100644
--- a/drivers/spi/spi-sh-msiof.c
+++ b/drivers/spi/spi-sh-msiof.c
@@ -638,6 +638,17 @@ static int sh_msiof_wait_for_completion(struct sh_msiof_spi_priv *p,
dev_err(&p->pdev->dev, "Tx DMA timeout\n");
return -ETIMEDOUT;
}
+ if (!rx) {
+ sh_msiof_write(p, IER, IER_TEOFE);
+
+ /* wait for tx fifo to be emptied */
+ if (!wait_for_completion_timeout(&p->done,
+ HZ)) {
+ dev_err(&p->pdev->dev,
+ "Tx fifo to be emptied timeout\n");
Please indent this line properly, messages can violate 80-column limit.
+ return -ETIMEDOUT;
+ }
+ }
}
if (rx) {
if (!wait_for_completion_timeout(&p->done_dma_rx,
[...]
MBR, Sergei
