Re: [PATCH 3/8] spi: sh-msiof: Fix MSIOF address for DMAC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06.09.2017 12:42, Geert Uytterhoeven wrote:
Hi Dirk,

On Wed, Sep 6, 2017 at 12:09 PM, Dirk Behme <dirk.behme@xxxxxxxxxxxx> wrote:
On 06.09.2017 11:22, Geert Uytterhoeven wrote:
On Wed, Sep 6, 2017 at 9:05 AM, Dirk Behme <dirk.behme@xxxxxxxxxxxx>
wrote:

From: Ryo Kataoka <ryo.kataoka.wt@xxxxxxxxxxx>

MSIOF Base Address H'E6xx can be accessed by CPU and DMAC.
MSIOF Base Address H'E7xx for DMAC was removed from H/W manual.

Signed-off-by: Ryo Kataoka <ryo.kataoka.wt@xxxxxxxxxxx>
Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
Signed-off-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>


NAKed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

The MSIOF Base Address for DMAC was removed only from the R-Car Gen2/Gen3
manuals. It still affects e.g. R-Mobile APE6.

Do we have a nice run time detection for that?

The current driver code just looks at the DTS, cfr. the comment:

     /* The DMA engine uses the second register set, if present */


Ok, yes, thanks.

So this patch is completely superfluous, even in the BSP, correct?

Will drop it for the next round, hoping that it doesn't result in too much rebase hassle ;)

Best regards

Dirk




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux