Re: [PATCH 1/2] clk: renesas: add R8A7797 CPG core clock definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sergei,

On Wed, Aug 23, 2017 at 2:52 PM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> Add macros usable by the device tree sources to reference the R8A7797 CPG
> clocks  by index.
>
> Based on the original (and large) patch by Daisuke Matsushita
> <daisuke.matsushita.ns@xxxxxxxxxxx>.

Please refer to Table 8.2c ("List of Clocks [R-Car V3M]") of the R-Car Series,
3rd Generation Hardware User's Manual (Rev. 0.55, Jun. 30, 2017).

> Signed-off-by: Vladimir Barinov <vladimir.barinov@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
> ---
>  include/dt-bindings/clock/r8a7797-cpg-mssr.h |   48 +++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> Index: linux/include/dt-bindings/clock/r8a7797-cpg-mssr.h
> ===================================================================
> --- /dev/null
> +++ linux/include/dt-bindings/clock/r8a7797-cpg-mssr.h

Please use "r8a77970-cpg-mssr.h", to follow the new 5-digit scheme started
with r8a77995.

> @@ -0,0 +1,48 @@
> +/*
> + * Copyright (C) 2016 Renesas Electronics Corp.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */
> +#ifndef __DT_BINDINGS_CLOCK_R8A7797_CPG_MSSR_H__
> +#define __DT_BINDINGS_CLOCK_R8A7797_CPG_MSSR_H__

...R8A77970...

> +
> +#include <dt-bindings/clock/renesas-cpg-mssr.h>
> +
> +/* r8a7797 CPG Core Clocks */
> +#define R8A7797_CLK_Z2                 0

#define R8A77970_...

> +#define R8A7797_CLK_CSIREF             26

The CSIREF clock was dropped in Rev. 0.54 of the datasheet.
Please remove it.

> +#define R8A7797_CLK_FRAY               27
> +#define R8A7797_CLK_CP                 28
> +#define R8A7797_CLK_CPEX               29
> +#define R8A7797_CLK_R                  30
> +#define R8A7797_CLK_OSC                        31

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux