Hi Julia, On Wed, Aug 16, 2017 at 8:59 PM, Julia Lawall <julia.lawall@xxxxxxx> wrote: > On line 149, it looks like one extal should instead be xtal. Thank you, that is correct. Fixed. ------ Forwarded message ---------- > Date: Thu, 17 Aug 2017 02:43:28 +0800 > From: kbuild test robot <fengguang.wu@xxxxxxxxx> > To: kbuild@xxxxxx > Cc: Julia Lawall <julia.lawall@xxxxxxx> > Subject: [renesas-drivers:clk-renesas-for-v4.14 10/11] > drivers/clk/renesas/rcar-usb2-clock-sel.c:149:5-17: duplicated argument to > && or || > > CC: kbuild-all@xxxxxx > CC: linux-renesas-soc@xxxxxxxxxxxxxxx > TO: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > CC: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git clk-renesas-for-v4.14 > head: 344fae7f354bdb869115212a56d39d5f2034466d > commit: 0b2934329320899150286a7fdec9c7d143d0bdb9 [10/11] clk: renesas: rcar-usb2-clock-sel: Add R-Car USB 2.0 clock selector PHY > :::::: branch date: 11 hours ago > :::::: commit date: 11 hours ago > >>> drivers/clk/renesas/rcar-usb2-clock-sel.c:149:5-17: duplicated argument to && or || > > # https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/commit/?id=0b2934329320899150286a7fdec9c7d143d0bdb9 > git remote add renesas-drivers https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git > git remote update renesas-drivers > git checkout 0b2934329320899150286a7fdec9c7d143d0bdb9 > vim +149 drivers/clk/renesas/rcar-usb2-clock-sel.c > > 0b293432 Yoshihiro Shimoda 2017-07-25 116 > 0b293432 Yoshihiro Shimoda 2017-07-25 117 static int rcar_usb2_clock_sel_probe(struct platform_device *pdev) > 0b293432 Yoshihiro Shimoda 2017-07-25 118 { > 0b293432 Yoshihiro Shimoda 2017-07-25 @149 if (!priv->extal && !priv->extal) { > 0b293432 Yoshihiro Shimoda 2017-07-25 150 dev_err(dev, "This driver needs usb_extal or usb_xtal\n"); > 0b293432 Yoshihiro Shimoda 2017-07-25 151 return -ENOENT; > 0b293432 Yoshihiro Shimoda 2017-07-25 152 } Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
