Hi Shimoda-san, On Wed, Aug 9, 2017 at 2:19 PM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote: > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > This patch adds SCIF{0,1,2,3,4,5} pins, groups and functions to R8A77995 > SoC. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > --- a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c > +/* - SCIF3 ------------------------------------------------------------------ */ > +static const unsigned int scif3_data_a_pins[] = { > + /* RX, TX */ > + RCAR_GP_PIN(2, 31), RCAR_GP_PIN(4, 00), > +}; > +static const unsigned int scif3_data_a_mux[] = { > + RX3_A_MARK, TX3_A_MARK, > +}; > +static const unsigned int scif3_clk_a_pins[] = { > + /* SCK */ > + RCAR_GP_PIN(2, 30), > +}; > +static const unsigned int scif3_clk_a_mux[] = { > + SCK3_A_MARK, > +}; > +static const unsigned int scif3_data_b_pins[] = { > + /* RX, TX */ > + RCAR_GP_PIN(1, 29), RCAR_GP_PIN(1, 31), RX3_B is GP1_30... > +}; > +static const unsigned int scif3_data_b_mux[] = { > + RX3_B_MARK, TX3_B_MARK, > +}; > +static const unsigned int scif3_clk_b_pins[] = { > + /* SCK */ > + RCAR_GP_PIN(1, 30), ... and SCK3_B is GP1_29 according to Rev0.4 of the R-Car D3 pin function datasheet. > +}; > +static const unsigned int scif3_clk_b_mux[] = { > + SCK3_B_MARK, > +}; Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in sh-pfc-for-v4.14 with the above fixed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds