> -----Original Message----- > From: Simon Horman [mailto:horms@xxxxxxxxxxxx] > Sent: 09 August 2017 09:36 > To: Biju Das <biju.das@xxxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland > <mark.rutland@xxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>; > Russell King <linux@xxxxxxxxxxxxxxx>; Chris Paterson > <Chris.Paterson2@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-renesas- > soc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 0/3] Add SMP support > > On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote: > > This series aims to add SMP support for r8a7743 SoC. > > > > This series has been tested against Linux-next tag 20170727 and > > renesas-dev branch. > > It seems that these patches are targeted at the renesas tree. > The best practice in that case is to base patches on the latest devel branch. > Please consider doing so in future. > > The patches themselves seem good to me, however, I would like to enquire > about testing. In particular, have you tested CPU hotplug and suspend to RAM > with these patches (and without in the case of the latter)? I have tested CPU hotplug with this patch and it works ok. Currently iWave platform doesn't support STR I guess. But we should check the changes on other M2 platforms to prove that things don't break. [>] > I am cautious about any regressions that may creep in when going from UP to > SMP. > > > > Biju Das (3): > > dt-bindings: apmu: Document r8a7743 support > > ARM: dts: r8a7743: Add APMU node and second CPU core > > ARM: dts: r8a7743: Add OPP table for frequency scaling > > > > .../devicetree/bindings/power/renesas,apmu.txt | 3 ++- > > arch/arm/boot/dts/r8a7743.dtsi | 25 ++++++++++++++++++++++ > > 2 files changed, 27 insertions(+), 1 deletion(-) > > > > -- > > 1.9.1 > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.