> -----Original Message----- > From: Simon Horman [mailto:horms@xxxxxxxxxxxx] > Sent: 09 August 2017 09:53 > To: Biju Das <biju.das@xxxxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland > <mark.rutland@xxxxxxx>; Wolfram Sang <wsa@xxxxxxxxxxxxx>; Magnus > Damm <magnus.damm@xxxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; > Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; > linux-renesas-soc@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/2] ARM: dts: r8a7743: Add I2C DT support > > On Tue, Aug 08, 2017 at 12:24:09PM +0100, Biju Das wrote: > > Add the I2C[0-5] devices to the r8a7743 device tree. > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > --- > > This patch has been tested against Linux-next tag 20170727 and renesas-dev > branch. > > This patch depends on > > https://www.mail-archive.com/linux-renesas-soc@xxxxxxxxxxxxxxx/msg1700 > > 8.html > > As per the patch at the link above it seems that these patches are targeted at > the renesas tree. The best practice in that case is to base patches on the latest > devel branch. Please consider doing so in future. > > I would also slightly prefer if dependencies were referenced by name, in this > case: > > * [PATCH 2/3] ARM: dts: r8a7743: Add APMU node and second CPU core > > or > > * [PATCH 0/3] Add SMP support > > Also including a link is fine by me. > > > It would also be useful if you described the dependency as a conflict (merge- > time), compile-time or run-time. Thanks Simon. I will take care this next time. > As for the patch itself, it looks good to me. > > > arch/arm/boot/dts/r8a7743.dtsi | 97 > > ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 97 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7743.dtsi > > b/arch/arm/boot/dts/r8a7743.dtsi index 8c46f62..14222c72 100644 > > --- a/arch/arm/boot/dts/r8a7743.dtsi > > +++ b/arch/arm/boot/dts/r8a7743.dtsi > > @@ -18,6 +18,15 @@ > > #address-cells = <2>; > > #size-cells = <2>; > > > > +aliases { > > +i2c0 = &i2c0; > > +i2c1 = &i2c1; > > +i2c2 = &i2c2; > > +i2c3 = &i2c3; > > +i2c4 = &i2c4; > > +i2c5 = &i2c5; > > +}; > > + > > cpus { > > #address-cells = <1>; > > #size-cells = <0>; > > @@ -339,6 +348,94 @@ > > dma-channels = <15>; > > }; > > > > +/* The memory map in the User's Manual maps the cores to > bus > > + * numbers > > + */ > > +i2c0: i2c@e6508000 { > > +#address-cells = <1>; > > +#size-cells = <0>; > > +compatible = "renesas,i2c-r8a7743", > > + "renesas,rcar-gen2-i2c"; > > +reg = <0 0xe6508000 0 0x40>; > > +interrupts = <GIC_SPI 287 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 931>; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg 931>; > > +i2c-scl-internal-delay-ns = <6>; > > +status = "disabled"; > > +}; > > + > > +i2c1: i2c@e6518000 { > > +#address-cells = <1>; > > +#size-cells = <0>; > > +compatible = "renesas,i2c-r8a7743", > > + "renesas,rcar-gen2-i2c"; > > +reg = <0 0xe6518000 0 0x40>; > > +interrupts = <GIC_SPI 288 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 930>; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg 930>; > > +i2c-scl-internal-delay-ns = <6>; > > +status = "disabled"; > > +}; > > + > > +i2c2: i2c@e6530000 { > > +#address-cells = <1>; > > +#size-cells = <0>; > > +compatible = "renesas,i2c-r8a7743", > > + "renesas,rcar-gen2-i2c"; > > +reg = <0 0xe6530000 0 0x40>; > > +interrupts = <GIC_SPI 286 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 929>; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg 929>; > > +i2c-scl-internal-delay-ns = <6>; > > +status = "disabled"; > > +}; > > + > > +i2c3: i2c@e6540000 { > > +#address-cells = <1>; > > +#size-cells = <0>; > > +compatible = "renesas,i2c-r8a7743", > > + "renesas,rcar-gen2-i2c"; > > +reg = <0 0xe6540000 0 0x40>; > > +interrupts = <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 928>; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg 928>; > > +i2c-scl-internal-delay-ns = <6>; > > +status = "disabled"; > > +}; > > + > > +i2c4: i2c@e6520000 { > > +#address-cells = <1>; > > +#size-cells = <0>; > > +compatible = "renesas,i2c-r8a7743", > > + "renesas,rcar-gen2-i2c"; > > +reg = <0 0xe6520000 0 0x40>; > > +interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 927>; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg 927>; > > +i2c-scl-internal-delay-ns = <6>; > > +status = "disabled"; > > +}; > > + > > +i2c5: i2c@e6528000 { > > +/* doesn't need pinmux */ > > +#address-cells = <1>; > > +#size-cells = <0>; > > +compatible = "renesas,i2c-r8a7743", > > + "renesas,rcar-gen2-i2c"; > > +reg = <0 0xe6528000 0 0x40>; > > +interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>; > > +clocks = <&cpg CPG_MOD 925>; > > +power-domains = <&sysc R8A7743_PD_ALWAYS_ON>; > > +resets = <&cpg 925>; > > +i2c-scl-internal-delay-ns = <110>; > > +status = "disabled"; > > +}; > > + > > scifa0: serial@e6c40000 { > > compatible = "renesas,scifa-r8a7743", > > "renesas,rcar-gen2-scifa", "renesas,scifa"; > > -- > > 1.9.1 > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
