Hi Wolfram,
On 2017/8/8 4:51, Wolfram Sang wrote:
Hi Shawn,
On Mon, Aug 07, 2017 at 09:32:45AM +0800, Shawn Lin wrote:
We to some extent should tolerate R1_OUT_OF_RANGE for open-ending
mode as it is expected behaviour and most of the backup partition
tables should be located near some the last blocks which will always
make open-ending read exceed the capcity of cards.
Fixes: 9820a5b11101 ("mmc: core: for data errors, take response of stop cmd into account")
Fixes: a04e6bae9e6f (mmc: core: check also R1 response for stop commands)
Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
Thanks a lot for debugging and working on this issue! I think the above
reason is correct, yet I wonder if we shouldn't implement it
differently: how about introducing a new #define called STOP_ERRORS
which does not include R1_OUT_OF_RANGE and use it instead of CMD_ERRORS?
I'm fine with that as mmc_blk_has_cmd_err is now only used to check stop
command.
Kind regards,
Wolfram
