Hi Wolfram, On Mon, Jul 17, 2017 at 5:12 PM, Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > Because the smallest clock divider we can select is 1, 'clks_per_sec' > must be the same type as 'rate'. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- a/drivers/watchdog/renesas_wdt.c > +++ b/drivers/watchdog/renesas_wdt.c > @@ -112,8 +112,7 @@ static int rwdt_probe(struct platform_device *pdev) > { > struct rwdt_priv *priv; > struct resource *res; > - unsigned long rate; > - unsigned int clks_per_sec; > + unsigned long rate, clks_per_sec; If you make this change, you should also update rwdt_priv.clks_per_sec (yes I know it's removed in a later patch in this series). > int ret, i; > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds