On Wed, Jul 12, 2017 at 3:27 PM, Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote:
> The existing code gives an incorrect pointer value.
> The buffer pointer 'buf' was of type unsigned short *, and 'count' was a
> number in bytes. A cast of buf should have been used.
>
> However,instead of casting, just change the code to use u32 pointers.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Fixes: 8185e51f358a: ("mmc: tmio-mmc: add support for 32bit data port")
> Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> if (is_read) {
> sd_ctrl_read32_rep(host, CTL_SD_DATA_PORT,
> - (u32 *)data, 1);
> + &data, 1);
I would use the opportunity to merge the two above lines, now they fit
on a single line.
> + memcpy(buf32, &data, count);
> } else {
> - memcpy(data, buf8, count);
> + memcpy(&data, buf32, count);
> sd_ctrl_write32_rep(host, CTL_SD_DATA_PORT,
> - (u32 *)data, 1);
> + &data, 1);
Likewise.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
