Hello Sergei, > From: Sergei Shtylyov [mailto:sergei.shtylyov@xxxxxxxxxxxxxxxxxx] > Sent: 11 July 2017 13:12 > > Hello! > > On 07/10/2017 06:32 PM, Biju Das wrote: > > > Add a new compatible string for the RZ/G1M (R8A7743) SoC. > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > --- > > v1->v2 > > * Changed the subject > > * re-formatted the required properties > > > > .../devicetree/bindings/net/renesas,ravb.txt | 29 +++++++++++++------ > --- > > 1 file changed, 17 insertions(+), 12 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/renesas,ravb.txt > > b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > index b519503..4717bc2 100644 > > --- a/Documentation/devicetree/bindings/net/renesas,ravb.txt > > +++ b/Documentation/devicetree/bindings/net/renesas,ravb.txt > > @@ -4,19 +4,24 @@ This file provides information on what the device > > node for the Ethernet AVB interface contains. > > > > Required properties: > > -- compatible: "renesas,etheravb-r8a7790" if the device is a part of R8A7790 > SoC. > > - "renesas,etheravb-r8a7791" if the device is a part of R8A7791 SoC. > > - "renesas,etheravb-r8a7792" if the device is a part of R8A7792 SoC. > > - "renesas,etheravb-r8a7793" if the device is a part of R8A7793 SoC. > > - "renesas,etheravb-r8a7794" if the device is a part of R8A7794 SoC. > > - "renesas,etheravb-r8a7795" if the device is a part of R8A7795 SoC. > > - "renesas,etheravb-r8a7796" if the device is a part of R8A7796 SoC. > > - "renesas,etheravb-rcar-gen2" for generic R-Car Gen 2 compatible > interface. > > - "renesas,etheravb-rcar-gen3" for generic R-Car Gen 3 compatible > interface. > > +- compatible: Must contain one or more of the following: > > No, it can't contain more than one SoC specific value. Surely it can contain both "renesas,etheravb-r8a7743" and "renesas,etheravb-rcar-gen2" for example? As indeed dictated by the instruction further down: > > + When compatible with the generic version, nodes must list the > > + SoC-specific version corresponding to the platform first followed by > > + the generic version. Kind regards, Chris
